Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cost Surface): Fixes a bug in the insertion of Cost Surface PUs for projects without a shapefile [MRXN23-525] #1623

Conversation

KevSanchez
Copy link
Collaborator

Also includes script to fix incorrect pu data in the DB

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@KevSanchez KevSanchez requested a review from hotzevzl January 11, 2024 09:43
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marxan ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 9:37am

@KevSanchez
Copy link
Collaborator Author

KevSanchez commented Jan 11, 2024

I didn't think that for such a simple fix it would be worth to include a whole new test from scratch, so I didn't include one considering the time we have, if that's ok with you @hotzevzl

…or projects without a shapefile

Also includes script to fix incorrect pu data in the DB
@KevSanchez KevSanchez force-pushed the fix/api/MRXN23-525-cloning-failure-when-incorrect-cost-surface-pu-data branch from e1d279e to 4dda93a Compare January 16, 2024 09:35
@KevSanchez KevSanchez changed the title fix(Cost Surface): Fixes a bug in the insertion of Cost Surface PUs for projects without a shapefile fix(Cost Surface): Fixes a bug in the insertion of Cost Surface PUs for projects without a shapefile [MRXN23-525] Jan 17, 2024
@KevSanchez KevSanchez merged commit 4c0e849 into develop Jan 17, 2024
61 checks passed
@KevSanchez KevSanchez deleted the fix/api/MRXN23-525-cloning-failure-when-incorrect-cost-surface-pu-data branch January 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants