Refactor disabling parameters options

Vizzuality · Dec 17, 2024 · 7b4fd2e · 7b4fd2e
1 parent 59c80b7
commit 7b4fd2e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 12 deletions.
diff --git a/client/src/app/(overview)/url-store.ts b/client/src/app/(overview)/url-store.ts
@@ -23,6 +23,19 @@ import { TABLE_VIEWS } from "@/containers/overview/table/toolbar/table-selector"
 
 const SUB_ACTIVITIES = RESTORATION_ACTIVITY_SUBTYPE;
 
+interface ParameterOption {
+  label: string;
+  value: string;
+  disabled?: boolean;
+}
+
+export interface Parameter {
+  key: keyof Omit<z.infer<typeof filtersSchema>, "keyword">;
+  label: string;
+  className: string;
+  options: ParameterOption[];
+}
+
 export const filtersSchema = z.object({
   [FILTER_KEYS[0]]: z.string().optional(),
   [FILTER_KEYS[1]]: z.nativeEnum(PROJECT_SIZE_FILTER),

diff --git a/client/src/containers/overview/header/parameters/index.tsx b/client/src/containers/overview/header/parameters/index.tsx
@@ -6,7 +6,7 @@ import {
 import { z } from "zod";
 
 import { FILTER_KEYS } from "@/app/(overview)/constants";
-import { useGlobalFilters } from "@/app/(overview)/url-store";
+import { Parameter, useGlobalFilters } from "@/app/(overview)/url-store";
 import { filtersSchema } from "@/app/(overview)/url-store";
 
 import { INITIAL_COST_RANGE } from "@/containers/overview/filters/constants";
@@ -19,7 +19,8 @@ import {
   SelectTrigger,
   SelectValue,
 } from "@/components/ui/select";
-export const PROJECT_PARAMETERS = [
+
+export const PROJECT_PARAMETERS: Parameter[] = [
   {
     key: FILTER_KEYS[1],
     label: "Project size",
@@ -51,6 +52,7 @@ export const PROJECT_PARAMETERS = [
       {
         label: PROJECT_PRICE_TYPE.OPEN_BREAK_EVEN_PRICE,
         value: PROJECT_PRICE_TYPE.OPEN_BREAK_EVEN_PRICE,
+        disabled: true,
       },
     ],
   },
@@ -94,7 +96,7 @@ export default function ParametersProjects() {
           <Label htmlFor={parameter.label}>{parameter.label}</Label>
           <Select
             name={parameter.label}
-            defaultValue={filters[parameter.key]}
+            defaultValue={String(filters[parameter.key])}
             onValueChange={(v) => {
               handleParameters(v, parameter.key);
             }}
@@ -107,9 +109,7 @@ export default function ParametersProjects() {
                 <SelectItem
                   key={option.value}
                   value={option.value}
-                  disabled={
-                    option.value === PROJECT_PRICE_TYPE.OPEN_BREAK_EVEN_PRICE
-                  }
+                  disabled={option?.disabled}
                 >
                   {option.label}
                 </SelectItem>

diff --git a/client/src/containers/overview/project-details/parameters/index.tsx b/client/src/containers/overview/project-details/parameters/index.tsx
@@ -7,7 +7,7 @@ import { atom, useAtom } from "jotai";
 import { z } from "zod";
 
 import { FILTER_KEYS } from "@/app/(overview)/constants";
-import { filtersSchema } from "@/app/(overview)/url-store";
+import { filtersSchema, Parameter } from "@/app/(overview)/url-store";
 
 import { Label } from "@/components/ui/label";
 import {
@@ -26,7 +26,7 @@ const INITIAL_FILTERS_STATE: Partial<z.infer<typeof filtersSchema>> = {
 
 const filtersAtom = atom(INITIAL_FILTERS_STATE);
 
-export const PROJECT_PARAMETERS = [
+export const PROJECT_PARAMETERS: Parameter[] = [
   {
     key: FILTER_KEYS[1],
     label: "Project size",
@@ -58,6 +58,7 @@ export const PROJECT_PARAMETERS = [
       {
         label: PROJECT_PRICE_TYPE.OPEN_BREAK_EVEN_PRICE,
         value: PROJECT_PRICE_TYPE.OPEN_BREAK_EVEN_PRICE,
+        disabled: true,
       },
     ],
   },
@@ -99,7 +100,7 @@ export default function ParametersProjects() {
           <Label htmlFor={parameter.label}>{parameter.label}</Label>
           <Select
             name={parameter.label}
-            defaultValue={filters[parameter.key]}
+            defaultValue={String(filters[parameter.key])}
             onValueChange={(v) => {
               handleParameters(v, parameter.key);
             }}
@@ -112,9 +113,7 @@ export default function ParametersProjects() {
                 <SelectItem
                   key={option.value}
                   value={option.value}
-                  disabled={
-                    option.value === PROJECT_PRICE_TYPE.OPEN_BREAK_EVEN_PRICE
-                  }
+                  disabled={option?.disabled}
                 >
                   {option.label}
                 </SelectItem>