project creation: ignores restoration years when creating conservatio…

…n project
Vizzuality · Dec 18, 2024 · 8cb5c38 · 8cb5c38
1 parent a90b1e6
commit 8cb5c38
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/client/src/containers/projects/new/index.tsx b/client/src/containers/projects/new/index.tsx
@@ -67,17 +67,16 @@ export const onSubmit = async (data: CreateCustomProjectForm) => {
     {},
   );
 
-  const validYears = // @ts-expect-error fix later
-    (originalValues.parameters.restorationYearlyBreakdown as number[])
-      .map((v, index) => {
-        // if (!v) return undefined;
+  const isRestoration = data.activity === ACTIVITY.RESTORATION;
 
-        return {
+  const validYears = isRestoration // @ts-expect-error fix later
+    ? (originalValues.parameters.restorationYearlyBreakdown as number[])
+        .map((v, index) => ({
           year: index == 0 ? -1 : index,
           hectares: v,
-        };
-      })
-      .filter((v) => v.hectares > 0);
+        }))
+        .filter((v) => v.hectares > 0)
+    : [];
 
   const {
     // @ts-expect-error fix later
@@ -96,7 +95,7 @@ export const onSubmit = async (data: CreateCustomProjectForm) => {
           // @ts-expect-error fix later
           restParameters.plantingSuccessRate / 100,
       }),
-      ...(originalValues.activity === ACTIVITY.RESTORATION && {
+      ...(isRestoration && {
         ...(validYears.length > 0 && {
           restorationYearlyBreakdown: validYears.map(({ year, hectares }) => ({
             year,