fix signUp bug, refactor tests

Vizzuality · Oct 13, 2024 · 9c0283a · 9c0283a
1 parent 655646f
commit 9c0283a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api/src/modules/auth/authentication.service.ts b/api/src/modules/auth/authentication.service.ts
@@ -79,7 +79,7 @@ export class AuthenticationService {
 
   async signUp(user: User, signUpDto: SignUpDto): Promise<void> {
     const { oneTimePassword, newPassword } = signUpDto;
-    if (await this.isPasswordValid(user, oneTimePassword)) {
+    if (!(await this.isPasswordValid(user, oneTimePassword))) {
       throw new UnauthorizedException();
     }
     user.isActive = true;

diff --git a/api/test/integration/auth/create-user.spec.ts b/api/test/integration/auth/create-user.spec.ts
@@ -67,7 +67,7 @@ describe('Create Users', () => {
     expect(response.status).toBe(HttpStatus.CONFLICT);
     // And the user should receive a message containing  "Email already exists"
     expect(response.body.errors[0].title).toBe(
-      `Email ${testUser.email} already exists`,
+      `User with email ${testUser.email} already exists`,
     );
   });