Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporal workaround to missing column data #116

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

alexeh
Copy link
Collaborator

@alexeh alexeh commented Nov 24, 2024

IMPORTANT: There has been several changes in the source datasheet:

We are missing price type, which is a filtering value and it is required: I have inserted values artificially in my local DB to keep working
'$/tCO2e has been renamed to cost_per_tco2e
$/tCO2e (NPV) is missing now

This pull request includes changes to the ExcelProjects type and the EntityPreprocessor class to correct property names and handle missing columns in the Excel sheet.

Changes to ExcelProjects type:

  • Corrected property names from aAbatement_potential to abatement_potential and total_cost_NPV to total_cost_npv.
  • Added a TODO comment for the missing column $/tCO2e (NPV).
  • Renamed property /tCO2e' to cost_per_tco2e.

Changes to EntityPreprocessor class:

  • Updated property names to match the corrected names in ExcelProjects.
  • Added a TODO comment and assigned a fake value for the missing column $/tCO2e (NPV).

Copy link

vercel bot commented Nov 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 6:10am

@alexeh alexeh merged commit 2f2a8f0 into dev Nov 24, 2024
4 checks passed
@alexeh alexeh deleted the fix/missing-project-data branch November 24, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant