Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scorecard view instead of repo #129

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Use scorecard view instead of repo #129

merged 3 commits into from
Dec 5, 2024

Conversation

catalin-oancea
Copy link
Collaborator

This pull request includes significant changes to refactor the project scorecard functionality by replacing the ProjectsScorecardRepository with a new ProjectScorecardView and integrating it into the ProjectsService. The most important changes include removing the ProjectsScorecardRepository, updating the ProjectsService to handle scorecard logic, and modifying the ProjectsController to use the updated service.

Refactoring Project Scorecard Functionality:

  • Removed ProjectsScorecardRepository and its methods from projects-scorecard.repository.ts.
  • Updated ProjectsService to include methods for fetching and filtering project scorecards using the new ProjectScorecardView entity. [1] [2]
  • Added ProjectScorecardView entity to represent the project scorecard view in the database, including necessary transformations and view columns.

Controller and Module Updates:

  • Updated ProjectsController to use ProjectsService for fetching project scorecards instead of ProjectsScorecardRepository.
  • Modified ProjectsModule to import ProjectScorecardView and remove ProjectsScorecardRepository.

DTO and Entity Adjustments:

  • Removed the ProjectScorecardDto type from projects-scorecard.dto.ts as it is no longer needed.
  • Added ProjectScorecardView to COMMON_DATABASE_ENTITIES in db-entities.ts. [1] [2]

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:38pm

@alexeh alexeh merged commit 7e47e50 into dev Dec 5, 2024
4 checks passed
@alexeh alexeh deleted the feature/scorecard-view branch December 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants