Fix/missing capex in npv cost details #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes focused on the
CostCalculator
class, import optimizations, and modifications to theProject
entity. The most important changes are summarized below:Changes to
CostCalculator
class:operationExpenditure
property from theCostCalculator
class to avoid duplication and potential confusion. (api/src/modules/calculations/cost.calculator.ts
) [1] [2]Import optimizations:
custom-project.factory.ts
file by removing unused imports and consolidating necessary ones. (api/src/modules/custom-projects/input-factory/custom-project.factory.ts
)Changes to
Project
entity:scoreCardRating
column to theProject
entity with a default value ofPROJECT_SCORE.MEDIUM
. This column uses thePROJECT_SCORE
enum. (shared/entities/projects.entity.ts
)PROJECT_SCORE
import in theprojects.entity.ts
file to support the newscoreCardRating
column. (shared/entities/projects.entity.ts
)Changes to DTOs:
operationExpenditure
field from theCustomProjectCostDetails
type to align with changes in theCostCalculator
class. (shared/dtos/custom-projects/custom-project-output.dto.ts
)