Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/missing capex in npv cost details #137

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

alexeh
Copy link
Collaborator

@alexeh alexeh commented Dec 5, 2024

This pull request includes several changes focused on the CostCalculator class, import optimizations, and modifications to the Project entity. The most important changes are summarized below:

Changes to CostCalculator class:

  • Removed redundant operationExpenditure property from the CostCalculator class to avoid duplication and potential confusion. (api/src/modules/calculations/cost.calculator.ts) [1] [2]

Import optimizations:

  • Cleaned up imports in the custom-project.factory.ts file by removing unused imports and consolidating necessary ones. (api/src/modules/custom-projects/input-factory/custom-project.factory.ts)

Changes to Project entity:

  • Added a new scoreCardRating column to the Project entity with a default value of PROJECT_SCORE.MEDIUM. This column uses the PROJECT_SCORE enum. (shared/entities/projects.entity.ts)
  • Included the PROJECT_SCORE import in the projects.entity.ts file to support the new scoreCardRating column. (shared/entities/projects.entity.ts)

Changes to DTOs:

  • Removed the operationExpenditure field from the CustomProjectCostDetails type to align with changes in the CostCalculator class. (shared/dtos/custom-projects/custom-project-output.dto.ts)

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:56am

@alexeh alexeh merged commit 69dec16 into dev Dec 5, 2024
4 checks passed
@alexeh alexeh deleted the fix/missing-capex-in-npv-cost-details branch December 5, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant