TBCCT-158 Backend base data upload #156
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alepefe
force-pushed
the
feat/tbcct-158
branch
from
2a3a4ff to
fe70a91
Compare
| @@ -260,6 +260,8 @@ jobs: | |||
| backoffice: | |||
| image: $ECR_REGISTRY/$ECR_REPOSITORY_ADMIN:$IMAGE_TAG | |||
| restart: always | |||
| environment: | |||
| NODE_ENV: production | |||
There was a problem hiding this comment.
Why do we need to pass the env here?
There was a problem hiding this comment.
Because if I want to work with a container locally for testing purposes, the variable was passed in directly like this pnpm --filter backoffice run start:prod and the environment property of a docker compose file service was not working, I could not pass NODE_ENV=development.
This is just for comfort but we could fall back to the previous approach.
|
|
||
| @Controller() | ||
| @UseGuards(JwtAuthGuard, RolesGuard) | ||
| @UseGuards(JwtCookieAuthGuard, RolesGuard) |
There was a problem hiding this comment.
I see the point of this, but wouldn't this disable the functionality of uploading the file through a jwt-authenticated POST request? (with no cookies)
Could we have both?
There was a problem hiding this comment.
Basically, the frontend does not save to the client the JWT it uses to send requests to the backend.
Andrés told me he saw in the nextjs documentation that you can customize the library's implementation at your own risk.
Therefore, in order to provide a full bidirectionaladminjs -> api integration, the api generates the adminjs session cookie and adminjs can also authenticate an admin with a session cookie.
| @@ -214,7 +229,7 @@ const start = async () => { | |||
| ); | |||
|
|
|||
| app.use(admin.options.rootPath, adminRouter); | |||
|
|
|||
| admin.watch() | |||
There was a problem hiding this comment.
Yes, it does like nodemon but for adminjs.
…trategy and some refactors
…lable in the backend through some backoffice views
…ackoffice and update pnpm lock file
alepefe
force-pushed
the
feat/tbcct-158
branch
from
4515cad to
f79761d
Compare
This pull request includes significant changes to the authentication module, backoffice service, and the addition of a new file ingestion feature. The most important changes include adding a new custom passport strategy, refactoring the backoffice service, and implementing a file ingestion page in the backoffice.
Authentication Module Updates:
passport-customdependency inapi/package.jsonto support custom authentication strategies.BackofficeServicefromauth.module.tsand updated its import path inauthentication.controller.ts. [1] [2] [3]BackofficeSessionStrategyand integrated it into theauthentication.module.ts. [1] [2] [3] [4]JwtCookieAuthGuardto handle JWT and backoffice session authentication.import.controller.tsto useJwtCookieAuthGuardinstead ofJwtAuthGuard. [1] [2]Backoffice Service Refactoring:
backoffice.service.tsand added a new one with enhanced functionality, including cookie generation and session retrieval. [1] [2]backoffice.module.tsto encapsulate the backoffice service and its dependencies.File Ingestion Feature:
backoffice/index.tsto include the new file ingestion page and ensure it is properly loaded and watched. [1] [2] [3]Dependency and Configuration Updates:
styled-components,react, and related type definitions tobackoffice/package.jsonandpnpm-lock.yamlto support the new file ingestion feature. [1] [2] [3] [4] [5] [6]tsconfig.jsonin the backoffice to include.tsxfiles.