Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: standardize table header and cell text styling #191

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

atrincas
Copy link
Collaborator

@atrincas atrincas commented Dec 19, 2024

Changes

  • Added reusable HeaderText and CellText components for consistent text styling across table
  • Standardized font sizes and weights using these components
  • Updated column headers with more precise labels (e.g., added "tCO2e/yr" unit)
  • Enhanced visual distinction between CapEx and OpEx in Total Cost column using color coding
  • Replaced generic <span> and <p> elements with semantic components

Visual Changes

  • All table headers now use consistent text-xs font size and normal font weight
  • All cell values now use consistent text-sm font size and normal font weight
  • CapEx (blue-500) and OpEx (blue-200) are now visually distinguished in the Total Cost column header
  • Added proper spacing between CapEx and OpEx labels using &nbsp;

Technical Details

  • Created two new components:
    • HeaderText: Standardizes header text styling
    • CellText: Standardizes cell text styling
  • Both components maintain consistent text-xs font-normal styling

This PR improves the visual consistency and readability of the table while making the code more maintainable through component reuse.

Fixes Jira comment

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 2:09pm

@atrincas atrincas requested a review from andresgnlez December 19, 2024 14:08
@atrincas atrincas merged commit c91fa3e into dev Dec 20, 2024
3 checks passed
@atrincas atrincas deleted the feat/updateColumnTitlesOverviewTable branch December 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants