[N/A] consistent "no results" in tables #251
Merged
+62
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the table components and their usage in various parts of the application. The main focus is on improving the table's appearance and functionality, as well as adding new utility components for better code reuse.
Improvements to table components:
client/src/components/ui/table.tsx
: Modified theScrollableTable
andTableHead
components to ensure the table takes full height and adjusted the table head styles. [1] [2]Enhancements to table utilities:
client/src/containers/overview/table/utils.tsx
: AddedComponentProps
import and introduced a newNoResults
component for displaying a "No results" message in tables. [1] [2] [3]Updates to table usage in views:
client/src/containers/overview/table/view/key-costs/index.tsx
: Utilized the newNoResults
component and added conditional rendering based onisSuccess
and data length. [1] [2] [3] [4]client/src/containers/overview/table/view/overview/index.tsx
: Applied similar updates as inkey-costs
view for consistency. [1] [2] [3] [4]client/src/containers/overview/table/view/scorecard-prioritization/index.tsx
: Incorporated theNoResults
component and updated conditional rendering logic. [1] [2] [3] [4]Minor adjustments:
e2e/tests/projects/projects-overview-table.spec.ts
: Removed unused import and added a wait for the response in the test setup. [1] [2]