[TBCCT-275] fix(api): Remove ecosystem dependant assumptions for conservation activity type (Refactor to reduce technical debt needed)

[alepefe]

This pull request focuses on updating the data transfer objects (DTOs) and related imports to use new schema-based DTOs instead of the previous class-validator-based DTOs. Here are the most important changes:

DTO Updates:

• Replaced OverridableAssumptions with OverridableAssumptionsDto in assumptions.repository.ts, sequestration-rate.calculator.ts, and other related files. [1] [2] [3]
• Replaced OverridableCostInputs with OverridableCostInputsDto in cost.calculator.ts, data.repository.ts, and other related files. [1] [2] [3]
• Removed old DTOs project-assumptions.dto.ts, project-cost-inputs.dto.ts, create-custom-project-dto.ts, and conservation-project-params.dto.ts. [1] [2] [3] [4]
• Added new schema-based DTOs in create-custom-project.dto.ts.

Repository and Service Updates:

• Updated AssumptionsRepository to use the new DTOs and added a condition to return restoration rate only for restoration activities. [1] [2]
• Updated CustomProjectsService and CustomProjectsController to use the new CreateCustomProjectDto. [1] [2]

Import Cleanups:

• Removed unnecessary imports related to the old DTOs from various files. [1] [2] [3]

These changes ensure that the project now uses the new schema-based DTOs, which simplifies validation and improves consistency across the codebase.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tnc-blue-carbon-cost-tool-ghps	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 11:59am

[alexeh]

Nice one @alepefe LGTM. I just left some minor comments.

However, since this touches critical parts, we really need to thoroughly tests the implementation to make sure we do not introduce any regression.

Also, lots of zod schema changes are present, so I'd like @agnlez 's review and input as well. I'll add him as reviewer

[agnlez]

Being checking project creation with both scenarios: conservation and restoration and, in both cases, the same restrictions apply as we had in the previous version. So I would say LGTM 👍🏻

[alexeh]

This is very cool!!

Been testing it a bit, seems to work fine with some caveats I detected but they are already present in dev so not related to this branch.

HOWEVER, given the magnitude of the changes, let's wait for today's meeting before pushing this forward. I'll try to have someone testing this more in depth