[TBCCT-22] Profile page #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agnlez
force-pushed
the
TBCCT-22-fe-profile-page
branch
from
bbf262a to
67e7685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to both the backend and frontend parts of the project, focusing on email service refactoring, status code corrections, and enhancements to the user interface components.
Backend Changes:
Email Service Refactoring:
NodemailerEmailServicewithEmailProviderFactoryinemail.module.tsto support different email services based on environment. (email.module.ts)EmailProviderFactoryto dynamically provide email service implementations based on environment configuration. (email.provider.ts)MockEmailServiceto handleSendMailDTOand ensure compatibility with Jest for testing. (mock-email.service.ts)Status Code Correction:
201 Createdto200 OKfor user update operations to correctly reflect the operation result. (users.controller.ts)200 OKinstead of201 Created. (users-me.spec.ts)Frontend Changes:
UI Components and Pages:
AlertDialogandDialogcomponents using Radix UI for consistent and accessible dialog interfaces. (alert-dialog.tsx,dialog.tsx) [1] [2]ConfirmEmailPageandProfilePagewith necessary hooks and query client prefetching for better user experience and performance. (confirm-email/[token]/page.tsx,profile/page.tsx) (client/src/app/auth/confirm-email/[token]/page.tsxR1-R5, client/src/app/profile/page.tsxR4-R23)Toastercomponent for displaying toast notifications globally. (layout.tsx,toaster.tsx) [1] [2]Dependencies:
package.jsonto include new dependencies for Radix UI components. (package.json)These changes collectively improve the codebase by enhancing modularity, correcting status codes, and providing a more robust and user-friendly frontend.