Skip to content

Commit

Permalink
chore(Dockerfile): Remove unnecessary code and comments
Browse files Browse the repository at this point in the history
- Removed the `COPY --from=deps /opt/app/node_modules ./node_modules` line from the Dockerfile as it was not needed.
- Also removed some commented out lines and unnecessary comments for better readability.

feat(docusaurus.config.ts): Update onBrokenMarkdownLinks to 'throw'

- Updated the `onBrokenMarkdownLinks` field in the Docusaurus configuration file to `'throw'` instead of `'warn'`. This will now throw an error when broken markdown links are encountered.

fix(package.json): Correct port number in start and serve scripts

- Corrected the port number in the `start` and `serve` scripts of the package.json file. Changed it from `5001` to `5000`.
  • Loading branch information
BillChirico committed Nov 6, 2023
1 parent 0aa9569 commit 97dae34
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
8 changes: 0 additions & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,12 @@
# Use a larger node image to do the build for native deps (e.g., gcc, python)
FROM node:lts-alpine AS deps

WORKDIR /opt/app
# Copy package.json and package-lock.json to the working directory
COPY package.json package-lock.json ./
# Install production dependencies only
RUN npm ci --only=production

# Stage 2: Build the application
FROM node:lts-alpine AS builder

WORKDIR /opt/app
# Copy all files from the current directory to the working directory in the container
COPY . .
# Copy node_modules from the "deps" stage
COPY --from=deps /opt/app/node_modules ./node_modules
# Build the application
RUN npm run build

Expand Down
2 changes: 1 addition & 1 deletion docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const config: Config = {
projectName: 'Volvox.Apollo', // Usually your repo name.

onBrokenLinks: 'throw',
onBrokenMarkdownLinks: 'warn',
onBrokenMarkdownLinks: 'throw',

// Even if you don't use internationalization, you can use this field to set
// useful metadata like html lang. For example, if your site is Chinese, you
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
"private": true,
"scripts": {
"docusaurus": "docusaurus",
"start": "docusaurus start --port 5001",
"start": "docusaurus start --port 5000",
"build": "docusaurus build",
"swizzle": "docusaurus swizzle",
"deploy": "docusaurus deploy",
"clear": "docusaurus clear",
"serve": "docusaurus serve --port 5001",
"serve": "docusaurus serve --port 5000",
"write-translations": "docusaurus write-translations",
"write-heading-ids": "docusaurus write-heading-ids",
"typecheck": "tsc"
Expand Down

0 comments on commit 97dae34

Please sign in to comment.