Skip to content

Commit

Permalink
Merge branch 'main' into VIV-2296-use-inline-time-picker
Browse files Browse the repository at this point in the history
  • Loading branch information
RichardHelm authored Feb 18, 2025
2 parents 0f60790 + f91c783 commit 665e651
Show file tree
Hide file tree
Showing 19 changed files with 411 additions and 437 deletions.
4 changes: 2 additions & 2 deletions .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"libs/components": "4.15.0",
"libs/vue-wrappers": "4.15.0",
"libs/components": "4.16.1",
"libs/vue-wrappers": "4.16.1",
"libs/eslint-plugin": "1.4.0"
}
10 changes: 8 additions & 2 deletions apps/docs/content/_data/components.json
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,14 @@
},
{
"title": "Header",
"page": "legacy",
"markdown": "./libs/components/src/lib/header/README.md"
"description": "The header component can be used to display a header at the top of a page or section.",
"variations": "./libs/components/src/lib/header/VARIATIONS.md",
"guidelines": "./libs/components/src/lib/header/GUIDELINES.md",
"hideGuidelines": "true",
"hideAccessibility": "true",
"code": "./libs/components/src/lib/header/README.md",
"useCases": "./libs/components/src/lib/header/USE-CASES.md",
"accessibility": "./libs/components/src/lib/header/ACCESSIBILITY.md"
},
{
"title": "Divider",
Expand Down
14 changes: 14 additions & 0 deletions libs/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,20 @@ This log was last generated on Thu, 26 Jan 2023 14:40:25 GMT and should not be m

<!-- Start content -->

## [4.16.1](https://github.com/Vonage/vivid-3/compare/vivid-v4.16.0...vivid-v4.16.1) (2025-02-18)


### Bug Fixes

* **file-picker:** set aria-label on base (VIV-2326) ([#2132](https://github.com/Vonage/vivid-3/issues/2132)) ([21e923a](https://github.com/Vonage/vivid-3/commit/21e923a61ab297df63270f237c883277c27be7a4))

## [4.16.0](https://github.com/Vonage/vivid-3/compare/vivid-v4.15.0...vivid-v4.16.0) (2025-02-14)


### Bug Fixes

* **slider, range-slider:** handle zero step (VIV-2271) ([#2134](https://github.com/Vonage/vivid-3/issues/2134)) ([6650690](https://github.com/Vonage/vivid-3/commit/6650690b09bea10567ccfcb58c84948f7d7f69a4))

## [4.15.0](https://github.com/Vonage/vivid-3/compare/vivid-v4.14.4...vivid-v4.15.0) (2025-02-13)


Expand Down
2 changes: 1 addition & 1 deletion libs/components/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vonage/vivid",
"version": "4.15.0",
"version": "4.16.1",
"type": "module",
"module": "./index.js",
"main": "./index.cjs",
Expand Down
10 changes: 5 additions & 5 deletions libs/components/src/lib/dialog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -478,11 +478,11 @@ The dialog has a default `--dialog-max-block-size`. If the content is larger, th

| Name | Description |
| ---------------- | ---------------------------------------------------------- |
| **Action-items** | Use for adding action items to the bottom of the dialog |
| **Body** | Add custom content to the dialog's body |
| **Footer** | Add additional content to the bottom of the dialog. |
| **Graphic** | Add graphic element to dialog. Overrides the icon property |
| **Main** | Override a card's predefined template |
| **action-items** | Use for adding action items to the bottom of the dialog |
| **body** | Add custom content to the dialog's body |
| **footer** | Add additional content to the bottom of the dialog. |
| **graphic** | Add graphic element to dialog. Overrides the icon property |
| **main** | Override a card's predefined template |

</div>

Expand Down
12 changes: 8 additions & 4 deletions libs/components/src/lib/divider/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ See the [Decorative Divider](/components/divider/use-cases/#decorative-divider)

### Properties

| Name | Type | Description |
| ------------- | ------------------------------------- | -------------------------- |
| `orientation` | `horizontal` (default), `vertical` | Controls the orientation |
| `role` | `separator` (default), `presentation` | Controls the semantic role |
<div class="table-wrapper">

| Name | Type | Description |
| --------------- | ------------------------------------- | -------------------------- |
| **orientation** | `horizontal` (default), `vertical` | Controls the orientation |
| **role** | `separator` (default), `presentation` | Controls the semantic role |

</div>
10 changes: 0 additions & 10 deletions libs/components/src/lib/file-picker/file-picker.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
createFormHTML,
elementUpdated,
fixture,
getBaseElement,
getControlElement,
} from '@vivid-nx/shared';
import type { Button } from '../button/button';
Expand Down Expand Up @@ -102,15 +101,6 @@ describe('vwc-file-picker', () => {
const labelElement = element.shadowRoot?.querySelector('label');
expect(labelElement).toBeNull();
});

it('should set aria-label on base element if label is set', async function () {
const labelText = 'label';
element.label = labelText;
await elementUpdated(element);
expect(getBaseElement(element).getAttribute('aria-label')).toEqual(
labelText
);
});
});

describe('value', function () {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const FilePickerTemplate = (context: VividElementDefinitionContext) => {
x.setButtonTag(context.tagFor(Button));
x.setIconTag(context.tagFor(Icon));
}}
<div class="base" aria-label="${(x) => x.label}">
<div class="base">
${when(
(x) => x.label,
html<FilePicker>`<label>${(x) => x.label}</label>`
Expand Down
Empty file.
Empty file.
Loading

0 comments on commit 665e651

Please sign in to comment.