Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): Make sure create session returned JSON, and fixed return type #913

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

dragonmantank
Copy link
Contributor

Description

  • Corrected a bug introduced where Form Submission requests weren't setting the accept header, this now sets it to application/json
  • Corrected an issue where the return value of the video Create Session call was accidentally changed from an array to an object

Motivation and Context

These were two bugs that were stopping calls to video's Create Session endpoint from returning properly. The calls succeeded, we just didn't report back the correct info to the developer.

Testing Details

Manual and unit tests

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank merged commit 28ac0df into 3.x Feb 7, 2024
13 checks passed
@dragonmantank dragonmantank deleted the video-session-create-fix branch February 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants