Pull Request for Universal Phone Mount - Voron 2.4r2 #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapleLeafMakers
suggested changes
Dec 24, 2023
…nted_With_Galaxy_A3.jpg
…xy_Mini_S5570.jpg
…ic_Main_Assembly.jpg
Compressed the JPGs with hopefully minimal quality loss. Let me know if it's enough, should total around 5-6mb now. Corrected the misspellings, sorry about those. Removed the license file. Fixed the image links, I had originally /Images/xx.jpg on my first pull but it wasn't working on this one so it got me confused. Works fine without the / at the start. Thanks |
|
Clever mod, and looks good to me! |
|
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅Whitespace checker
Mod structure checker
STL corruption checker
STL rotation checker
WARNING:
|
| Item | Result | Original orientation | Suggested orientation |
|---|---|---|---|
| slider_190mm.stl |  |
 |
|
| slider_90mm.stl |  |
 |
|
| slider_150mm.stl |  |
 |
|
| slider_80mm.stl |  |
 |
|
| slider_100mm.stl |  |
 |
|
| slider_170mm.stl |  |
 |
FAILURE: ❌
EXCEPTION: 💀
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
|
On closer inspection, I think I agree with the warnings detected by the STL checker, the slider parts would probably print better upside-down. though they both look perfectly printable to me. |
I oriented the sliders this way because there's an unchamfered lip on the elastic retainer meant to prevent the elastic band from sliding off before installing the claw. Would need supports to be printed if I flipped the part. I agree that it's technically easier to bridge the smaller wholes instead of the retainer section but I'm not sure the AI is accounting for the unchamfered lip and support requirement. Let me know if the changes are required, I can easily flip the parts and either chamfer the lip or place some supports. |
|
No need to change it, I think that's fine. the bot isn't always right, and they should print perfectly as-is. |
MapleLeafMakers
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which mods are added by this PR?
Universal_Phone_Mount
How was it tested?
Printed in ASA and mounted on my Voron 2.4r2, tested with a Samsung A3, Samsung Galaxy mini and a Samsung A52. Working as intended with the appropriate files and for the phones I have available for testing.
Any background context you want to provide?
Screenshots (if appropriate)
my mod adheres to these rules.
license