-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creative Live! Camera Mount #1018
Conversation
printer_mods/dankeeling/CreativeLiveCameraMount/STL/Creative_Live_Camera.stl
Outdated
Show resolved
Hide resolved
updated to relative images
…4_211032~3.jpg Removing extra image
printer_mods/dankeeling/CreativeLiveCameraMount/CAD/Creative_Live_Camera.3mf
Outdated
Show resolved
Hide resolved
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅Whitespace checker
Mod structure checker
WARNING:
|
Aha! We're missing a meta file that contains the information to merge the modification. If you have a look here https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file you'll hopefully see what needs to go into that file |
I forgot to include that, it's been added in the branch now. |
cleanup of URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling change updated
@DKsub -- thank you for working with us as we work out the kinks in our new PR process. It is very much appreciated! |
All good, happy to be a tester and help the community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't realize I had open requests.
Notice for other reviewers: my approval is not one from an exhaustive PR, I was just closing out my single comment that I somehow turned into a merge-stopping review. |
Which mods are added by this PR?
Trident, 2.4, any with 20x20 extrusions with space
How was it tested?
Printed in 3 different orientations in ABS, found the best one and changed STL accordingly. Included in instructions with print settings
Any background context you want to provide?
I could not find a mount for the inexpensive web camera, so designed one in OnShape.
Screenshots (if appropriate)
Included in the repo.
my mod adheres to these rules.
license