Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Avalonia, fix performance issues and bugs. #29

Merged
merged 30 commits into from
Mar 5, 2024
Merged

Upgrade Avalonia, fix performance issues and bugs. #29

merged 30 commits into from
Mar 5, 2024

Conversation

Vrabbers
Copy link
Owner

@Vrabbers Vrabbers commented Feb 28, 2024 •
edited
Loading

  • Upgrade Avalonia and make required changes;
  • Map theming;
  • Re-implement inertial panning;
  • Do not update when players don't move and they are off-screen;
  • Fix go mode warning and token box message boxes being too large;
  • Fix performance and issues with player update.
  • Make sure TTS works on Linux and macOS;
  • macOS build, test;
  • Fix CI.
  • Use proper DI or simplify structure;
  • Fix map render performance

Vrabbers and others added 22 commits January 29, 2024 21:44
@Vrabbers
Upgrade to .NET 8 and Avalonia 11.0.7
36e9a31 
This is not yet a complete upgrade, as some features have been momentarily removed, such as the map theming and the inertial scrolling. Also, analysis corrections have been applied where applicable. Bugs have not been fixed as well as many other idiosyncrasies. The Mac and Web workloads have not been looked at.
@Vrabbers
Fix some loose ends
68984b1
@Vrabbers
Cleanup, remove Web for now
0069abc
@Vrabbers
theme map
2d18acc
@Vrabbers
Clean up warnings and unuseds
2ad6968
@Vrabbers
and this as well...
ad8096c
@Vrabbers
Inertial pan, remove unused usings.
a558055
@Vrabbers
Make buttons full height to avoid misalignment
7f4c552
@Vrabbers
Collection expressions, primary constructors. Do not update if player…
5dba189 
…s have not moved (fixes #16)
@Vrabbers
Fix TTS, wrap long lines on message boxes.
bc42ea5
@vicr123
Update application name on macOS
0fad99a
@vicr123
Fix TTS on macOS
b74dab4
@Vrabbers
Fix bug where cancelling edit mode dialog would keep the button on. (f…
9bd76d9 
…ixes #21)
@Vrabbers
Player updating changes (fixes #31, #16)
ba87102
@Vrabbers
Further improvements to player update
391ce04
@Vrabbers
Improve PlayerUpdate event perf, fix flickering ComboBox bug.
751fbeb
@Vrabbers
UI improvements
74ac51d
@Vrabbers
Update linux.yaml
c4c0047
@Vrabbers
Fix other workflow files
aba96f3
@Vrabbers
This as well...
cd27f1a
@Vrabbers
Upgrade actions workflows
c7f7496
@Vrabbers
Update win.yaml
7df6951
@Vrabbers Vrabbers changed the title Upgrade Avalonia and fix some bugs Upgrade Avalonia, fix performance issues and bugs. Mar 3, 2024
@Vrabbers Vrabbers marked this pull request as ready for review March 3, 2024 05:27
@Vrabbers
Copy link
Owner Author

Vrabbers commented Mar 3, 2024

As for an Avalonia update, and fixing some bugs and low-hanging performance issues, I think this can be merged to main as-is, and since the map rendering change and backend changes are more significant do those as separate PRs.

@Vrabbers Vrabbers requested a review from vicr123 March 4, 2024 00:01
@Vrabbers Vrabbers requested a review from reflectronic March 4, 2024 00:01
@Vrabbers Vrabbers merged commit b81bd94 into main Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicr123 vicr123 vicr123 left review comments

@reflectronic reflectronic Awaiting requested review from reflectronic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vrabbers @vicr123