Adding steam tinker launch to possible downloads #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much easier to edit and maintain.
They were being set on the response buffer rather than the request, so they were not being sent to GitHub. It's important that we send them correctly so that GitHub's API changes doesn't break ProtonPlus in the future.
We request 1, so it should always be 1, but if GitHub returns multiple then we simply want the 0th (first) entry, so all we really care about is that there's at least 1 entry.
This just reduces risk of any future typos, by deriving the base path from the chosen parent path.
The "_with_default()" method automatically verifies that the member exists and is a string (not null, int, etc), otherwise it returns the default, in our case "" (empty string). This makes the member retrieval safer.
If "yad" was not installed, it always thought it was installed. The only time it failed was if it found yad but the version was too low.
All FileTests of steam.vala have now been reviewed and revised to have stricter logic which avoids data loss but still detects errors appropriately.
All files were being created with a silly "-rw-------" mode which doesn't make sense. The default has now been changed to use the normal, default Linux permissions of "-rw-r--r--" instead. The old behavior can still be triggered by passing `private_mode = true` as a flag, but it's no longer the default.
The UI state handler has been completely rewritten to address previous issues of complexity, code repetition, and maintainability. Key improvements include: - Simplified Architecture: The system has been unified into a single, cohesive structure, significantly reducing complexity and making it more intuitive to understand. - Improved Maintainability: Eliminated spaghetti and repeated logic, ensuring a cleaner, modular, and easily maintainable system. - Robustness: The new implementation is more robust, reducing potential edge case failures and ensuring smoother state transitions. Overall, the new UI state handler is now easier to read, maintain, and scale, while providing a strong foundation for future development.
- Fixed the broken window size that was causing "AdwOverlaySplitView" console errors due to the app's minimum allowed dimensions being too small. - Adjusted the default window size to 960x690 to ensure all supported Steam Runners fit within the app window without overflow. Verified at 1920x1080 and 4K with 100% and 200% screen scales. It now looks perfect everywhere.
Vysp3r
force-pushed
the
166-feature-adding-steam-tinker-launch-to-possible-downloads
branch
from
c623d8f to
dec310f
Compare
It's safer and more reliable.
Vysp3r
deleted the
166-feature-adding-steam-tinker-launch-to-possible-downloads
branch
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.