Simpler fix

Vzor- · Apr 27, 2024 · 54f1871 · 54f1871
1 parent b491f2e
commit 54f1871
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/qz/printer/info/NativePrinterMap.java b/src/qz/printer/info/NativePrinterMap.java
@@ -51,7 +51,12 @@ public ArrayList<PrintService> findMissing(boolean exhaustive, PrintService[] se
         ArrayList<PrintService> serviceList = new ArrayList<>(Arrays.asList(services)); // shrinking list drastically improves performance
 
         for(NativePrinter printer : values()) {
-            if (serviceList.contains(printer.getPrintService())) {
+            int index = serviceList.indexOf(printer.getPrintService());
+            if (index >= 0) {
+                // Java's `PrintService.equals(o)` method uses getName().equals(). This causes issues if a stale PrintService has been replaced
+                // by a new PrintService of the same name. For that reason, we always refresh the PrintService reference in NativePrinter.
+                // See: https://github.com/qzind/tray/issues/1259
+                printer.setPrintService(serviceList.get(index));
                 serviceList.remove(printer.getPrintService()); // existing match
             } else {
                 if(exhaustive) {