This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Python 3 compatibility #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the run.py files for the tutorials encountered a TabError following the Python 3 compatibility change. This fixes this error (mostly changes TAB+space to just TAB). There were also some minor errors with a few of the case tests due to using floats where there should be integers, which are fixed here as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a project with @ryancoe where we want to use Bemio, but we are using Python 3 as a base, while Bemio still requires Python 2. This addition allows Bemio to work with Python version >=3.3 while still being compatible with Python 2.
The majority of the additions were automated using the Python
2to3package and are rudimentary syntax changes (e.g.print '...'->print('...')). There are also two minor corrections indata_structures/wave_excitation.pyandio/nemoh.pydiscovered while running the case tests.python install_test.py allwas successfully run for both Python 2.7 and 3.9, but let me know if any other compatibility issues are discovered.