feat: Log users that joins guild #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabihoshi
reviewed
Apr 20, 2022
Comment on lines
+291
to
+293
| .AppendLine($"{Format.Bold("`Mention:`")} <@{user.Id}>") | ||
| .AppendLine($"{Format.Bold("`GuildId:`")} {log.GuildId}") | ||
| .AppendLine($"{Format.Bold("`IsBot: `")} {user.IsBot}") |
There was a problem hiding this comment.
These should also just be fields
sabihoshi
reviewed
Apr 20, 2022
Comment on lines
+295
to
+297
| .AddField("AccountCreationDate", user.CreatedAt.ToUniversalTimestamp(), true) | ||
| .AddField("JoinDate", log.JoinDate?.ToUniversalTimestamp(), true) | ||
| .AddField("FirstJoinDate", log.FirstJoinDate?.ToUniversalTimestamp(), true) |
sabihoshi
reviewed
Apr 20, 2022
Comment on lines
+18
to
+23
| public DateTimeOffset LogDate { get; set; } | ||
| public GuildUserEntity User { get; set; } | ||
| public DateTimeOffset? FirstJoinDate { get; set; } | ||
| public DateTimeOffset? JoinDate { get; set; } | ||
| public ulong GuildId { get; set; } | ||
| public ulong UserId { get; set; } |
There was a problem hiding this comment.
Should add a blank line in between them for consistency
sabihoshi
reviewed
Apr 20, 2022
Comment on lines
+14
to
+15
| FirstJoinDate = user.JoinedAt; | ||
| JoinDate = userJoinDate; |
There was a problem hiding this comment.
The JoinDate can be inferred from the LogDate so the only important thing is the FirstJoinDate
sabihoshi
requested changes
Apr 20, 2022
sabihoshi
force-pushed
the
main
branch
2 times, most recently
from
d018f0c to
7ca34a0
Compare
sabihoshi
force-pushed
the
main
branch
15 times, most recently
from
2d8b095 to
c8f7d9a
Compare
sabihoshi
force-pushed
the
main
branch
15 times, most recently
from
6cc092c to
2068250
Compare
sabihoshi
force-pushed
the
main
branch
4 times, most recently
from
819a4ad to
bc91328
Compare
sabihoshi
force-pushed
the
main
branch
2 times, most recently
from
b8fe246 to
c7c0ae8
Compare
sabihoshi
force-pushed
the
main
branch
3 times, most recently
from
4543d97 to
ebf7bb4
Compare
sabihoshi
force-pushed
the
main
branch
3 times, most recently
from
a2fe971 to
7466300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.