update to latest Hyrax / Ruby version #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
previously approved these changes
Aug 29, 2023
|
All specs are failing on 
👀 |
This commit will replace all instances of AdminSet.find_or_create_default_admin_set_id with Hyrax::AdminSetCreateService.find_or_create_default_admin_set.id.to_s because the former was deprecated.
This commit will fix various specs that were failing because of the Ruby 3.2.2 upgrade. At this point there should only be 4 failures left. ``` 879 examples, 4 failures, 38 pending Failed examples: rspec ./spec/models/bulkrax/pbcore_xml_entry_spec.rb:92 rspec ./spec/models/bulkrax/pbcore_xml_entry_spec.rb:87 rspec ./spec/models/bulkrax/pbcore_xml_entry_spec.rb:169 rspec ./spec/services/aapb/batch_ingest/csv_reader_spec.rb:30 ```
This commit pulls in the changes for the PbcoreXMLEntry spec from develop that passes.
…97-bulkrax-meets-valkyrie
|
i get the following trying to build this branch |
This was resolved by commenting out these two lines: https://github.com/WGBH-MLA/ams/blob/develop/Dockerfile#L69-L71 |
This work is still in progress. The valkyrie config file is commented out until we receive code for implementing adapters. We are using the object_factory config to utilize Valkyrie::ObjectFactory and lastly we added some changed to avoid errors when running an import. Issue: - scientist-softserv#97 Co-Authored-By: Kirk Wang <[email protected]> Co-Authored-By: LaRita Robinson <[email protected]>
…A/ams into ruby_tuesday_3.2_edition
WIP commit. We need to figure out how to transform their custom actor code into transactions. The child works are not getting created because it is no longer using GBH's custom hyrax actor stacks.
In this commit we are setting the child titles to be the same as the parent's title.
…date aapb status when called
maybe fix valkyrieobject load issue
add listener for save to essentracks, instantiations and assets.
…A/ams into ruby_tuesday_3.2_edition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to move your db from mysql to postgres -
MIGRATE_DB=1 dc up pgloaderthen start the app.