Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎬 Row actions #188

Merged
merged 4 commits into from
Nov 17, 2023
Merged

🎬 Row actions #188

merged 4 commits into from
Nov 17, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Nov 17, 2023

Row actions

Uses new @row_actions to combine action logic for one and multiple.

Example

Adapted from jowilf/starlette-admin#348 (comment)

@action(...)
@row_action(...)
async def start_batches(self, request, pks: list | int ) -> str:
  if not isinstance(pks, list):
      pks = [pks]
  ...

@mrharpo mrharpo added enhancement ➕ New feature or request maintenance 🔧 Updates and upgrades labels Nov 17, 2023
@mrharpo mrharpo self-assigned this Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (a223795) 67.32% compared to head (2cac4d7) 66.98%.

Files Patch % Lines
chowda/views.py 60.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   67.32%   66.98%   -0.34%     
==========================================
  Files          20       20              
  Lines        1016     1045      +29     
==========================================
+ Hits          684      700      +16     
- Misses        332      345      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo marked this pull request as ready for review November 17, 2023 20:42
@mrharpo mrharpo requested a review from afred November 17, 2023 20:43
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yes()

@mrharpo
Copy link
Contributor Author

mrharpo commented Nov 17, 2023

yes() makes it unreasonably fun to use!

@mrharpo mrharpo merged commit 46c19bd into main Nov 17, 2023
8 checks passed
@mrharpo mrharpo deleted the row-actions branch November 17, 2023 21:02
mrharpo added a commit that referenced this pull request Feb 26, 2024
* main:
  🍼 Ensure pip (#195)
  Adds pip to venv (#192)
  Adds venv to start of PATH (#191)
  Activates venv in production image (#190)
  🎬 Row actions (#188)
  🤖 Update dependencies (#186)
  📩 MMIF Download (#182)
  ⛓️ Metaflow links (#185)
  🎱 Fields: `Finished`, `Successful` (#184)
  ➕ Add MMIF to batch (#181)
  🤖 Update dependencies (#177)
  🔏 Requires valid access tokens for API calls (#173)
  🏞 `MMIF` source  (#168)
  ⌛ Expires all (#172)
  🤖 Update dependencies (#171)
  📄 Page title (#162)
  Fixes MediaFilesGuidsField, combines usage (#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request maintenance 🔧 Updates and upgrades
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants