Spec descendant frames' ongoing navigations block disableUntrustedNetwork promise from being resolved #210
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaochen-z
changed the title
blu25
reviewed
Feb 12, 2025
| [=iteration/continue=]. | ||
| 1. If |currentNavigable| is not a [=fenced navigable container/fenced navigable=]: | ||
|
|
||
| 1. If |currentNavigable|' [=navigable/ongoing navigation=] is a [=navigation ID=]: |
There was a problem hiding this comment.
Do we need to care if this is set to "traversal"?
| @@ -2099,7 +2109,9 @@ Several APIs specific to fenced frames are defined on the {{Fence}} interface. | |||
|
|
|||
| 1. [=map/Clear=] |config|'s [=fenced frame config instance/on network disabled promises=]. | |||
|
|
|||
| 1. Otherwise: | |||
| 1. If |networkCutoffReady| is false or |currentNavigable|' [=navigable/ongoing navigation=] is | |||
| a [=navigation ID=]: | |||
There was a problem hiding this comment.
We're checking if |currentNavigable|'s ongoing navigation is a navigation ID 3 times in this loop. It should probably be pulled out into its own variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #205
This PR only implements the change in algorithm "recalculate the untrusted network status of all fenced frame descendants".
The part that this algorithm should be called whenever a navigation commits will be done in a follow-up PR. I'm still investigating how to spec this. See previous comment on this.
Preview | Diff