Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default values for optional members in StorageBucketOptions. #115

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Remove default values for optional members in StorageBucketOptions. #115

merged 3 commits into from
Nov 28, 2023

Conversation

evanstade
Copy link
Collaborator

@evanstade evanstade commented Nov 28, 2023 •
edited by pr-preview bot
Loading

Fixes #99
Fixes #114

Preview | Diff

@evanstade evanstade requested a review from ayuishii November 28, 2023 19:10
ayuishii
ayuishii approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@ayuishii ayuishii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Evan Stade added 2 commits November 28, 2023 19:37
@evanstade evanstade merged commit fc359a1 into WICG:main Nov 28, 2023
github-actions bot added a commit that referenced this pull request Nov 28, 2023
@evanstade @github-actions
Remove default values for optional members in StorageBucketOptions. (#…
2c7b05b 
…115)

SHA: fc359a1
Reason: push, by evanstade

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@evanstade evanstade mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayuishii ayuishii ayuishii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nullable dictionary members don't seem necessary Dictionary exists checks don't make sense
2 participants
@evanstade @ayuishii