Remove Bidding Signals Format "V1" support #1390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes mention of the Trusted Bidding Signals V1 format, as well as the "Bidding-Signals-Format-Version: 2" header, as there's no plan for a version 3, and "version 2" can be easily confused with the KVv2 API. All responses will be assumed to be version 2.
MattMenke2
commented
Jan 28, 2025
| 1. [=Assert=] |isBiddingSignal| is true. | ||
| 1. Let |perInterestGroupData| be |signals|["`perInterestGroupData`"]. | ||
| 1. If |signals|["`keys`"] does not [=map/exist=], return « null, null ». | ||
| 1. Set |signals| to |signals|["`keys`"]. |
There was a problem hiding this comment.
This is a little awkward, and this entire method has a bunch of bugs (e.g., line 2711 should be before we set signals, a bunch of the returns only return two values instead of three, some places "set |signals| to null and return failure" (signals isn't even being returned, and wasn't passed in by the caller, so setting it to null doesn't do anything), etc.
I think fixing all of that is beyond the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes mention of the Trusted Bidding Signals V1 format, as well as the "Bidding-Signals-Format-Version: 2" header, as there's no plan for a version 3, and "version 2" can be easily confused with the KVv2 API. All responses will be assumed to be version 2.
Preview | Diff