[Spec] Fix minor bugs. #1392
Merged
[Spec] Fix minor bugs. #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: * Make fetch trusted signals always return 3 values. It was sometimes returning only two. * Make "score and rank a bid" take a policy container, and pass it to "fetch and decode trusted scoring signals", which requires one as an argument. * Pass a policyContainer to "score and rank a bid" calls. * Fix one "score and rank a bid" call, which wasn't being passed a realTimeContributionsMap.
qingxinwu
approved these changes
Feb 2, 2025
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
qingxinwu
reviewed
Feb 3, 2025
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
qingxinwu
reviewed
Feb 3, 2025
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2025
SHA: 36a89d8 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
Preview | Diff