-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: group-by-origin execution mode. #905
base: main
Are you sure you want to change the base?
Conversation
@morlovich mind reviewing this? Select "hide whitespace" in the files changed tab will make the PR easier to review. |
@morlovich friendly ping |
@@ -1356,6 +1356,17 @@ To <dfn>parse an https origin</dfn> given a [=string=] |input|: | |||
<div algorithm> | |||
|
|||
To <dfn>build bid generators map</dfn> given an [=auction config=] |auctionConfig|: | |||
|
|||
<div class="note"> This algorithm builds an [=ordered map=] with: | |||
* key: An [=origin=], which is a buyer of [=auction config/interest group buyers=] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May this be easier to read with a tuple key? Though I guess how we only care about joining origin some of the time may make it messy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah really need to find a better way to do this. It's getting really complicated now with many layers, which is hard to understand and hard to maintain. It can go to a separate PR, but any suggestion will be appreciated.
spec.bs
Outdated
1. [=map/For each=] |joiningOrigin| → |perBiddingUrlGenerator| of |perSignalsUrlGenerator|: | ||
1. [=map/For each=] biddingUrl → |groups| of |perBiddingUrlGenerator|: | ||
1. Let |realmForOriginGroupMode| be null. | ||
1. [=list/For each=] |ig| of |groups|: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not that definitive in grouping, we do it opportunistically and order things based on priority... actually is there priority-ordering in the spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it step 6 of https://wicg.github.io/turtledove/#apply-interest-groups-limits-to-prioritized-list? But seems we don't have the part of calculating priority from priority vector.
Spec IG's group-by-origin execution mode, which attempt to re-use the execution environment for interest groups with the same script that were joined on the same top-level origin, which saves a lot of these initialization costs.
💥 Error: 400 Bad Request 💥
PR Preview failed to build. (Last tried on Mar 5, 2024, 4:47 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.