Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Fix build #949

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[Spec] Fix build #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,27 +2028,28 @@ To <dfn>build trusted bidding signals url</dfn> given a [=URL=] |signalsUrl|, an
|experimentGroupId|, and an [=origin=] |topLevelOrigin|:
1. Let |queryParamsList| be a new empty [=list=].

Note: These steps create a [=url/query=] of the form "`&<name>=<values in comma-delimited list>`". E.g.,
"`hostname=publisher1.com&keys=key1,key2&interestGroupNames=ad+platform,name2&experimentGroupId=1234`".
<br><br>These steps don't use the [=urlencoded serializer|application/x-www-form-urlencoded serializer=]
to construct the query string because it repeats a key if it has multiple values instead of a
comma-demilited list (e.g., "keys=key1&keys=key2", instead of "keys=key1,key2"), and it also
uses a different percent encode set from the Chrome implementation.
Note: These steps create a [=url/query=] of the form "`&<name>=<values in comma-delimited list>`".
E.g., "`hostname=publisher1.com&keys=key1,key2&interestGroupNames=ad+platform,name2&experimentGroupId=1234`".
<br><br>These steps don't use the [=urlencoded serializer|application/x-www-form-urlencoded
serializer=] to construct the query string because it repeats a key if it has multiple values
instead of a comma-demilited list (e.g., "`keys=key1&keys=key2`", instead of
"`keys=key1,key2`"), and it also uses a different percent encode set from the Chrome
implementation.

1. [=list/Append=] "hostname=" to |queryParamsList|.
1. [=list/Append=] the result of [=string/UTF-8 percent-encoding=] the
[=serialization of an origin|serialized=] |topLevelOrigin| using [=component percent-encode set=]
to |queryParamsList|.
1. If |keys| is not [=set/is empty|empty=]:
1. [=list/Append=] "&keys=" to |queryParamsList|.
1. [=list/Append=] "`&keys=`" to |queryParamsList|.
1. [=list/Extend=] |queryParamsList| with the result of [=encode trusted signals keys=] with
|keys|.
1. If |igNames| is not [=set/is empty|empty=]:
1. [=list/Append=] "&interestGroupNames=" to |queryParamsList|.
1. [=list/Append=] "`&interestGroupNames=`" to |queryParamsList|.
1. [=list/Extend=] |queryParamsList| with the result of [=encode trusted signals keys=] with
|igNames|.
1. If |experimentGroupId| is not null:
1. [=list/Append=] "&experimentGroupId=" to |queryParamsList|.
1. [=list/Append=] "`&experimentGroupId=`" to |queryParamsList|.
1. [=list/Append=] [=serialize an integer|serialized=] |experimentGroupId| to |queryParamsList|.
1. Let |fullSignalsUrl| be |signalsUrl|.
1. Set |fullSignalsUrl|'s [=url/query=] to the result of [=string/concatenating=] |queryParamsList|.
Expand All @@ -2069,15 +2070,15 @@ Note: When trusted scoring signals fetches are not batched, |renderURLs|'s [=lis
1. [=list/Append=] the result of [=string/UTF-8 percent-encoding=] |topLevelOrigin| using
[=component percent-encode set=] to |queryParamsList|.
1. If |renderURLs| is not [=set/is empty|empty=]:
1. [=list/Append=] "&renderURLs=" to |queryParamsList|.
1. [=list/Append=] "`&renderURLs=`" to |queryParamsList|.
1. [=list/Extend=] |queryParamsList| with the result of [=encode trusted signals keys=] with
|renderURLs|.
1. If |adComponentRenderURLs| is not [=set/is empty|empty=]:
1. [=list/Append=] "&adComponentRenderURLs=" to |queryParamsList|.
1. [=list/Append=] "`&adComponentRenderURLs=`" to |queryParamsList|.
1. [=list/Extend=] |queryParamsList| with the result of [=encode trusted signals keys=] with
|adComponentRenderURLs|.
1. If |experimentGroupId| is not null:
1. [=list/Append=] "&experimentGroupId=" to |queryParamsList|.
1. [=list/Append=] "`&experimentGroupId=`" to |queryParamsList|.
1. [=list/Append=] [=serialize an integer|serialized=] |experimentGroupId| to |queryParamsList|.
1. Set |signalsUrl|'s [=url/query=] to the result of [=string/concatenating=] |queryParamsList|.
1. return |signalsUrl|.
Expand Down