Add reportResult in Multi Seller Case Clarity #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I'm seeing in 9.5.11/19 [here](https://wicg.github.io/turtledove/#generate-and-score-bids), I believe this should be correct, and having this called out explicitly is worthwhile I'd say. @rdgordon-index seems to be seeing each reportResult triggered as well.
MattMenke2
approved these changes
Aug 8, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 8, 2024
SHA: 94c7e50 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Aug 12, 2024
SHA: 94c7e50 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I'm seeing in 9.5.11/19 here, I believe this should be correct, and having this called out explicitly is worthwhile I'd say. @rdgordon-index seems to be seeing each reportResult triggered as well.