-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAFT DOE to create Surrogate Model (updated) #303
base: develop
Are you sure you want to change the base?
Conversation
I made an unexpected abrupt merge on the previous |
I think it is ready for review. With the latest updates, the surrogate model is created using sparse Gaussian process (SGP) included in the SMT toolbox, and giving both very stable and accurate prediction, as R^2 values mostly fit within 0.99 or higher, if the parameter is well correlated by its own nature. Other types of Gaussian process methods created stability issues when the sample number increases more than a few hundreds. So, there is no meaning to explore other methodologies. |
Hi @yonghoonlee, thanks for putting this PR together! It looks like nice work. Some notes and questions:
|
@dzalkind Thank you for your review.
|
Hi @yonghoonlee, the comments should show up on this page (above): #303 |
@dzalkind I cannot find your code comments. Would you please let me know how I can access them? I do not see anything commented on my code from this page (or other places). |
except: | ||
pass | ||
|
||
if opt_options['design_variables']['control']['servo']['pitch_control']['ptfm_freq']['flag']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these sets of duplicated code be made into a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all variables can be processed in a consistent manner. So, making a function that works with every variables might not be easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzalkind This is the only remaining item that needs your attention. Otherwise, all other review comments are addressed.
A small bug fix in 0fa00a0 for MPI with 1 core. This is particularly necessary when single core is used with slurm. |
0fa00a0
to
f0f926d
Compare
Rebased the newest updates from develop branch onto this PR. The PR now needs to be tested again, so please do not merge onto the develop branch. |
Committer: Yong Hoon Lee <[email protected]>
…d unused surrogate_based_optimization schema
6b63c80
to
1564536
Compare
Purpose
This draft PR is to implement streamlined process of creating surrogate model out of design of experiment runs within runWEIS code. The reason for training surrogate model is to use in design coupling analysis, and ultimately in the Formulation Tool for WEIS (FTW) being developed by UIUC and U of Memphis.
The whole process is completely parallelized using MPI, so running DOE, processing recorder files, and training surrogate models can be done in any MPI-based parallel environment, including HPC.
PR#300 has an unexpected abrupt merge, so this new PR is created not to include unnecessary complications.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
In example 15 directory, run
or if MPI is available, run
or if under HPC environment, run slurm script.
Checklist
Put an
x
in the boxes that apply.