Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure time is correct #3

Closed
wants to merge 2 commits into from
Closed

Make sure time is correct #3

wants to merge 2 commits into from

Conversation

jgadelange
Copy link
Member

No description provided.

AoCH/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ThomBreugelmans ThomBreugelmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had completely missed this PR and is already fixed in main (I know, bad practice but didn't expect help on this side project 🙏 ).

However, while this fix might work, I want to make the remark that this happened because the pod this runs on is not located in the Netherlands. Not sure if it has a standard location, however as it might be subject to moving around this "fix" does not resolve the underlying issue, namely that timezones are not taken into account.
If the pod happens to run in the Netherlands, then this will still result in issues.

Thank you for making this PR and bringing it to our attention.

@jgadelange
Copy link
Member Author

I agree, much better solution 🚀 . Was planning on adding the timezone, but went for the easy solution for now because I wasn't in the mood to think on how to set the correct timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants