Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Payment Method Code #475

Merged
merged 3 commits into from
May 4, 2024
Merged

Cleanup Payment Method Code #475

merged 3 commits into from
May 4, 2024

Conversation

JoepdeJong
Copy link
Contributor

@JoepdeJong JoepdeJong commented May 4, 2024 •
edited
Loading

  • Create tests to test current logic
  • Use lambda functions
  • Remove exp4j package

@JoepdeJong JoepdeJong requested a review from praseodym May 4, 2024 17:17
@JoepdeJong JoepdeJong changed the title WIP: Cleanup Payment Method Code Cleanup Payment Method Code May 4, 2024
praseodym
praseodym approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@praseodym praseodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good to see some tests!

@praseodym praseodym merged commit 2267248 into master May 4, 2024
5 checks passed
@JoepdeJong JoepdeJong deleted the cleanup-payment-method branch May 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseodym praseodym praseodym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoepdeJong @praseodym