Add support for Google Wallet passes #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The passes don't work for anonymous checkouts, since you have to be a users, and the owner of the ticket when you want a google/apple wallet pass. Maybe we should hide the buttons if it was an anonymous checkout? |
|
does this mean data is shared with Google? |
This should work, but I will check. These passes aren't really tied to a user, since it's just a fancy QR-code display.
This is only done when a user clicks on the button, and only for that user. So I believe that is fine. |
dsluijk
changed the title
maartenweyns
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Google Wallet, since I am not in Apple's walled garden. It also adds the Apple Wallet button in two more places (confirmation email and the payment success screen).
Do not merge until the Wallet account is reviewed and approved.