Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement parent products #505

Merged
merged 6 commits into from
Sep 25, 2024
Merged

WIP: Implement parent products #505

merged 6 commits into from
Sep 25, 2024

Conversation

JoepdeJong
Copy link
Contributor

This PR allows for sharing stock between products inside an event, by linking the products to a parent product.

TODOs

  • Tests

@robertdijk
Copy link
Member

I think the max amount of tickets is now not enforced for the group. So the if the parent has max tickets allowed per user on 1, I can buy one of the parent, and one of the child. Is this the desired behaviour? If so, I think it should not be inherited, but individually configurable per product. Or it should be enforced.

@JoepdeJong
Copy link
Contributor Author

I think the max amount of tickets is now not enforced for the group. So the if the parent has max tickets allowed per user on 1, I can buy one of the parent, and one of the child. Is this the desired behaviour? If so, I think it should not be inherited, but individually configurable per product. Or it should be enforced.

it is easier to not inherit it, but i am not sure what is desired.. it is only to share availability between certain products in an event. i will ask the board to comment

@julian9499
Copy link
Contributor

@JoepdeJong Should this PR include a migration? If i remember my hibernation knowledge correctly you are adding columns to an existing table. The older products need to have a default value right?

@robertdijk
Copy link
Member

it is easier to not inherit it, but i am not sure what is desired.. it is only to share availability between certain products in an event. i will ask the board to comment

I added a PR to add this functionality! #506

@JoepdeJong
Copy link
Contributor Author

@JoepdeJong Should this PR include a migration? If i remember my hibernation knowledge correctly you are adding columns to an existing table. The older products need to have a default value right?

Fixed!

@robertdijk robertdijk merged commit 31ebee5 into master Sep 25, 2024
5 checks passed
@robertdijk robertdijk deleted the feature/parent-products branch September 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants