Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zettle plugin to wordpress website #32

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

robertdijk
Copy link
Member

This PR adds my Zettle Stock WordPress plugin to the website.
This plugin connects to Zettle and allows us to show the current stock of our items on our website.
This will be used for the book sale.

@robertdijk
Copy link
Member Author

Is this all I have to do to deploy it? Does it now also auto-update when I update the plugin?

@JoepdeJong
Copy link
Contributor

JoepdeJong commented Oct 8, 2023

Is this all I have to do to deploy it? Does it now also auto-update when I update the plugin?

yes.

but i think it is better to fork your repo into our organisation. where did you get the sourcecode from? maybe we can link it to that to ensure we get updates.

@JoepdeJong
Copy link
Contributor

JoepdeJong commented Oct 8, 2023

oh about auto-updating: the website only updates the plugins when it is redeployed. changing your repo does not trigger a deployment.

@robertdijk
Copy link
Member Author

but i think it is better to fork your repo into our organisation. where did you get the sourcecode from? maybe we can link it to that to ensure we get updates.

I wrote it 😋.
But I can still fork it on wisvch. Should I?

And how do the updates work now for the CH theme and CH plug-in?
Because I remember changing the theme and it was deployed within minutes.

@JoepdeJong
Copy link
Contributor

I wrote it 😋.

cool :)

And how do the updates work now for the CH theme and CH plug-in?
Because I remember changing the theme and it was deployed within minutes.

see
https://github.com/WISVCH/website/blob/9719b6500acf1df7a29b053d6a8ebad0c921a19d/entrypoint.sh#L44C1-L59C3

both are pulled upon initialising the pod. as far as i know, this is only triggered when https://github.com/WISVCH/website is updated, or when somebody manually triggers a new deployment.

as far as I know, updating https://github.com/WISVCH/rechallenge or https://github.com/WISVCH/wisvch-wordpress-plugin does not trigger a new build. maybe we can implement a hook that does this?

@robertdijk
Copy link
Member Author

I now transferred the repo to the CH organization (not my problem anymore 😋) so that should be good now.

For the deployment: I don't have enough rights to manually trigger a rebuild I think 🥺

@robertdijk robertdijk merged commit 84a6133 into main Oct 24, 2023
2 checks passed
@robertdijk robertdijk deleted the website-zettle-plugin branch October 24, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants