Replace strings with enum

WISVCH · Dec 9, 2017 · af590d2 · af590d2
1 parent b9e45db
commit af590d2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/main/java/ch/wisv/payments/model/eventsync/EventsSyncEnum.java b/src/main/java/ch/wisv/payments/model/eventsync/EventsSyncEnum.java
@@ -0,0 +1,7 @@
+package ch.wisv.payments.model.eventsync;
+
+public enum EventsSyncEnum {
+
+    PRODUCT_CREATE_EDIT,
+    PRODUCT_DELETE
+}
diff --git a/src/main/java/ch/wisv/payments/rest/eventsync/EventsSyncRestController.java b/src/main/java/ch/wisv/payments/rest/eventsync/EventsSyncRestController.java
@@ -14,6 +14,7 @@
 import java.nio.charset.Charset;
 import java.util.Base64;
 
+import static ch.wisv.payments.model.eventsync.EventsSyncEnum.valueOf;
 import static ch.wisv.payments.util.ResponseEntityBuilder.createResponseEntity;
 
 @RestController
@@ -56,11 +57,11 @@ public ResponseEntity<?> eventSync(HttpServletRequest request, @RequestBody Prod
             return createResponseEntity(HttpStatus.UNAUTHORIZED, "User is not authorized", null);
         }
 
-        switch (productEventsSync.getTrigger()) {
-            case "PRODUCT_CREATE_EDIT":
+        switch (valueOf(productEventsSync.getTrigger())) {
+            case PRODUCT_CREATE_EDIT:
                 this.createOrUpdate(productEventsSync);
                 break;
-            case "PRODUCT_DELETE":
+            case PRODUCT_DELETE:
                 eventsSyncProductService.deleteProduct(productEventsSync);
                 break;
             default: