-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Could you add how to obtain (and redirect) to Mollie after the post request? Also, thanks for removing those nasty whitespaces! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@@ -31,23 +31,42 @@ print(response.json()) | |||
``` | |||
|
|||
#### JavaScript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a note that fetch is not supported everywhere yet?
README.md
Outdated
productKeys: ['e44685c5-a360-467c-960d-29843a101bb1', '879941f4-43d1-4ff2-ad66-cbdf3b141cab'] | ||
} | ||
}); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a print statement for the result of the request, this way the user is immediately able to see what the response contains.
README.md
Outdated
}); | ||
``` | ||
|
||
Obtaining the status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add this to the python section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes 😄
README.md
Outdated
|
||
Obtaining the status: | ||
```js | ||
const request = await fetch('http://localhost:9000/api/orders/status/e44685c5-a360-467c-960d-29843a101bb1'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this example should use the order id from the request you have done above
The snippet was updated according to your feedback 😄 |
We may need to explain it in sjaars-terms, but let's leave that for a dedicated "code example" page. |
Fixes the JS part of #6