Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sp provision api feature #357

Open
wants to merge 65 commits into
base: sp-provision-api-feature
Choose a base branch
from

Conversation

gayanch
Copy link
Contributor

@gayanch gayanch commented Jul 9, 2018

No description provided.

gayanch and others added 30 commits June 28, 2018 15:29
@@ -0,0 +1,121 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright (c) 2015-2016, WSO2.Telco Inc. (http://www.wso2telco.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use correct year

.post(body)
.addHeader("authorization", "Basic " + encoding)
.addHeader("content-type", "application/x-www-form-urlencoded")
.addHeader("cache-control", "no-cache")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove
.addHeader("cache-control", "no-cache")
.addHeader("postman-token", "37e6d409-ba6d-b94d-50d2-273b7d671a84")

loginToAm(userName);
} catch (IOException ex) {
logInstance.error("IO Exception occured when trying to login to the user in Add subscription " +
"process" + ex.toString(), ex);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llogInstance.error("IO Exception occured when trying to login to the user in Add subscription " +

  •                "process" + ex.getMessage(), ex);
    


if (serviceProvider != null) {
InboundProvisioningConfig inboundProvisioningConfig = serviceProvider.getInboundProvisioningConfig();
InboundAuthenticationRequestConfig[] x = serviceProvider.getInboundAuthenticationConfig()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use meaningful name for x

*/
private LocalAuthenticatorConfig[] setLocalAuthenticatorConfigObject() {
LocalAuthenticatorConfig localAuthenticatorConfig1 = new LocalAuthenticatorConfig();
localAuthenticatorConfig1.setDisplayName("LOA");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use CONSTANTS

public static Connection getConnectionToAxiataDb() throws SQLException {
try {
Connection con = DbUtils.getDbConnection(DataSourceNames.WSO2TELCO_DEP_DB);
con.setAutoCommit(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not explicitly set this. we can define this in the data source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants