Fix untranslatable translation string. #8926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of splitting the strings in two to encompass the variable, better to merge as one string and then pull the variable using sprintf. Splitting as two means it would only be possible to translate the strings sensibly to languages which use the same SVO (Subject-Object-Verb) word order as English. For languages with different word order, subsequent translations would make no sense. By merging as one string, word order doesn't matter anymore, because translations can be arranged however needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of splitting the strings in two to encompass the variable, better to merge as one string and then pull the variable using sprintf.
Splitting as two means it would only be possible to translate the strings sensibly to languages which use the same SVO (Subject-Verb-Object) word order as English. For languages with different word order, subsequent translations would make no sense.
By merging as one string, word order doesn't matter anymore, because translations can be arranged however needed.
Because this file (
index.php) doesn't include or require any other PHP files (most notably, thelocale/function.phpfile, which is normally responsible for defining the__function and loading any necessary locale data), and appears instead to define the__function itself (where it simply returns the input value verbatim, without touching any locale data), it isn't entirely clear whether any of the apparent translation strings in this file are actually intended to ever be translated. However, given that the__function is being called for the strings instead of just echoing or printing the strings directly, I assume the__function as defined by this file is intended as either a temporary placeholder or as a fallback function, with plans to eventually have this file utilise existing locale data, either through including/requiringlocale/function.phpor some other means.