✨ feat : 지역 변환 api 구현 및 Kafka 설정 변경 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDonghyeo
approved these changes
May 31, 2024
| @@ -14,14 +14,20 @@ | |||
|
|
|||
| @RequiredArgsConstructor | |||
| @RestController | |||
| @RequestMapping("/weather") | |||
| @RequestMapping("/api/v1/weather") | |||
There was a problem hiding this comment.
헉 이거 일부러 /weather로 바꿔놨습니다...
api-gateway에서 prefix를 /weather 로 해놔서...
There was a problem hiding this comment.
아 제가 잘못 바꾼 줄 ㅋㅋ
변경하겠습니다
| public record GetWeatherRequest( | ||
| @NotBlank(message = "[ERROR] 위도 입력은 필수 입니다.") |
There was a problem hiding this comment.
혹시 Validation 대한민국 내 위도/경도 받는건 어떨까요??
@NotBlank(message = " 위도(lat) 값은 필수입니다.")
@DecimalMax(value = "132.0", inclusive = true, message = "위도(lat)는 대한민국 내에서만 가능합니다.")
@DecimalMin(value = "124.0", inclusive = true, message = "위도(lat)는 대한민국 내에서만 가능합니다.")
public double lat;
@NotBlank(message = " 경도(y) 값은 필수입니다.")
@DecimalMax(value = "43.0", inclusive = true, message = "경도(lon)는 대한민국 내에서만 가능합니다.")
@DecimalMin(value = "33.0", inclusive = true, message = "경도(lon)는 대한민국 내에서만 가능합니다.")
public double lon;There was a problem hiding this comment.
위도 경도 받는 api들 모두 적용하겠습니다~!
| @@ -31,38 +34,47 @@ public class KafkaConfig { | |||
| @Value("${spring.kafka.consumer.group-id}") | |||
| private String groupId; | |||
|
|
|||
| @Bean | |||
| public ProducerFactory<String, String> producerFactory() { | |||
| private <T> ProducerFactory<String, T> producerFactory(Class<T> valueClass) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☝️Issue Number
🔎 Key Changes
💌 To Reviewers