Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chores] Wallet certification and fixes #305

Merged
merged 9 commits into from
Aug 8, 2024
Merged

[chores] Wallet certification and fixes #305

merged 9 commits into from
Aug 8, 2024

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented Aug 8, 2024 •
edited
Loading

Description

  • WalletConnect certification fixes on sample wallet
  • Added to Wallet the ability of derive more than just one address out from the same seed phrase
  • Added to Wallet a simple ability to "switch" to a new account and emit proper accountsChanged event.
  • Added Connectivity check to core and throw exceptions when internet connection is gone
  • macOS and Web minor fixes for samples
  • Minor UI improvements on samples
  • Fix for SIWE 2.0 EIP-155 #303 (EIP-55 validation for SIWE)

Resolves # (issue)

How Has This Been Tested?

  • Integration tests
  • Manual tests

Tests coverage:

Screenshot 2024-08-08 at 13 59 12

Throws when no internet connection

RPReplay_Final1723113394.MP4

Switch to account and emit

demo.mov

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool marked this pull request as ready for review August 8, 2024 12:13
@quetool quetool changed the title Feature/wallet certification and fixes [chores] Wallet certification and fixes Aug 8, 2024
ganchoradkov
ganchoradkov approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left couple comments 💯

quetool and others added 2 commits August 8, 2024 15:29
ignaciosantise
ignaciosantise approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@ignaciosantise ignaciosantise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@quetool quetool merged commit 8b204bc into develop Aug 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov ganchoradkov approved these changes

@ignaciosantise ignaciosantise ignaciosantise approved these changes

@jakubuid jakubuid Awaiting requested review from jakubuid

@jackpooleywc jackpooleywc Awaiting requested review from jackpooleywc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quetool @ignaciosantise @ganchoradkov @CyberWake