Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connected Address API #148

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Connected Address API #148

merged 3 commits into from
Nov 6, 2023

Conversation

gigajuwels
Copy link
Contributor

Created address api to set defaults and fetch connected address

@gigajuwels gigajuwels requested a review from skibitsky November 3, 2023 00:45
skibitsky
skibitsky reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@skibitsky skibitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic! I had only two comments, let's resolve them and merge!

WalletConnectSharp.Sign/Models/Caip25Address.cs Outdated Show resolved Hide resolved
WalletConnectSharp.Sign/Controllers/AddressProvider.cs Outdated Show resolved Hide resolved
@skibitsky skibitsky merged commit 359340c into 2.0 Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skibitsky skibitsky skibitsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gigajuwels @skibitsky