Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): using the latest and manual image tag in the manual deploy #165

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Jan 18, 2024

Description

This PR fixes the error on the manual dispatch of the Deploy workflow with the default empty image tag by making the following changes:

  • Making the Release Version as an option with the following options:
    • latest - latest release tag.
    • manual - manual image tag version to deploy.
      • Using the manual tag only when the manual option is chosen.

How Has This Been Tested?

Tested by invoking the workflow from the branch.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother requested a review from xav January 18, 2024 15:50
@geekbrother geekbrother self-assigned this Jan 18, 2024
@geekbrother geekbrother marked this pull request as ready for review January 18, 2024 15:51
@geekbrother geekbrother requested a review from Elyniss as a code owner January 18, 2024 15:51
@geekbrother geekbrother force-pushed the fix/dispatch_deploy_latest branch from e379877 to e68de6a Compare January 22, 2024 10:35
@geekbrother geekbrother force-pushed the fix/dispatch_deploy_latest branch from e68de6a to 6033d63 Compare January 22, 2024 10:36
@geekbrother geekbrother changed the title fix(ci): using the latest image tag in the manual deploy fix(ci): using the latest and manual image tag in the manual deploy Jan 22, 2024
@geekbrother geekbrother merged commit 2cd571a into master Jan 22, 2024
15 of 19 checks passed
@geekbrother geekbrother deleted the fix/dispatch_deploy_latest branch January 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants