-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed sample app for 0.9.8 #40
base: master
Are you sure you want to change the base?
Conversation
Thanks - that looks good to me. Need to do some more testing later before merging. At a first test it failed when connecting to the wallet - did you try that? |
…r text configuration
So I'm actually testing against walletconnect.org. The bridge server seems to have some issues
|
Issues relating to the bridge server has been fixed |
Hi, what should I do if I want to integrate Uniswap on my own app? I just opened the Uniswap Dapp from Android.That is, the implementation of the wallet connection interface APP |
I think you are misunderstanding what this library does. If you want to integrate Uniswap (a dapp) into your app your should be using the web3 to send rpc requests to the blockchain and interact with the contract. WalletConnect is simply a protocol for connecting and signing transactions with a wallet, for example your app would build a transaction, lets say you want to swap a token on uniswap, you'd build the transaction then send it over WalletConnect library to bridge your app to some wallet(ie metamask) for signing and sending the signed transaction to the blockchain. This library simply creates a bridge from your app to metamask. The rest of the implementation you need to do with something like web3. A link to the web3 js docs |
oh sorry for letting this PR slip @JavonneM - crazy times currently - hope to be able to test and maybe merge this one soon |
Hello, can I connect to the Uniswap Dapp by integrating this library?If so, how should I do it?Thank you. Could you give me some advice |
When merge? |
Still awaiting @ligi to test and merge. I think they might be working on a new version of this though. |
Updated the repo so that the sample app can build with ease. This would probably require a version bump with the changes to
FullyQualifiedConfig
.Library Changes
toWCUri()
onFullyQualifiedConfig
Sample app changes
https://bridge.walletconnect.org
bridge)Demonstration
https://user-images.githubusercontent.com/4679874/119327954-d67a2980-bc83-11eb-92ab-04beb4120e63.mp4