Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sample app for 0.9.8 #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JavonneM
Copy link

@JavonneM JavonneM commented May 21, 2021

Updated the repo so that the sample app can build with ease. This would probably require a version bump with the changes to FullyQualifiedConfig.

Library Changes

  • Added toWCUri() on FullyQualifiedConfig

Sample app changes

  • Fixed the sample app
  • Fixed bridge server failing to parse bools
  • Navigation only occurs when the websocket is connected (Previously the websocket was timing out using https://bridge.walletconnect.org bridge)
  • After sending the transaction navigation occurs again to the wallet for the example app
  • Also added network config for sslip.io cleartext communication

Demonstration
https://user-images.githubusercontent.com/4679874/119327954-d67a2980-bc83-11eb-92ab-04beb4120e63.mp4

@ligi
Copy link
Collaborator

ligi commented May 21, 2021

Thanks - that looks good to me. Need to do some more testing later before merging. At a first test it failed when connecting to the wallet - did you try that?

@JavonneM
Copy link
Author

JavonneM commented May 24, 2021

Thanks - that looks good to me. Need to do some more testing later before merging. At a first test it failed when connecting to the wallet - did you try that?

So I'm actually testing against walletconnect.org. The bridge server seems to have some issues

2021-05-24 12:04:01.869 29677-29754/io.walletconnect.example.debug D/#####: Message: {"topic":"45474c95-4423-4997-bb35-61795884c9a8","type":"sub","payload":"","silent":true}
.example.debug W/System.err: com.squareup.moshi.JsonDataException: Expected a string but was BOOLEAN at path $.silent
....
2021-05-24 12:04:01.872 29677-29754/io.walletconnect.example.debug W/System.err:     at io.walletconnect.example.server.BridgeServer.onMessage(BridgeServer.kt:43)

https://bridge.walletconnect.org) websocket does time out sometimes though, tested it today and it seems to be working fine now. Ropsten and https://bridge.walletconnect.org network has constantly been congested for me, I've attached a video demo using walletconnect and Ropsten.

@JavonneM
Copy link
Author

Thanks - that looks good to me. Need to do some more testing later before merging. At a first test it failed when connecting to the wallet - did you try that?

So I'm actually testing against walletconnect.org. The bridge server seems to have some issues

2021-05-24 12:04:01.869 29677-29754/io.walletconnect.example.debug D/#####: Message: {"topic":"45474c95-4423-4997-bb35-61795884c9a8","type":"sub","payload":"","silent":true}
.example.debug W/System.err: com.squareup.moshi.JsonDataException: Expected a string but was BOOLEAN at path $.silent
....
2021-05-24 12:04:01.872 29677-29754/io.walletconnect.example.debug W/System.err:     at io.walletconnect.example.server.BridgeServer.onMessage(BridgeServer.kt:43)

https://bridge.walletconnect.org) websocket does time out sometimes though, tested it today and it seems to be working fine now. Ropsten and https://bridge.walletconnect.org network has constantly been congested for me, I've attached a video demo using walletconnect and Ropsten.

Issues relating to the bridge server has been fixed

@ww1997hj
Copy link

Hello! I am a beginner of Android. Download the project you provided and report an error when it runs. How to solve this problem?
微信图片_20210622201210

@JavonneM
Copy link
Author

Hello! I am a beginner of Android. Download the project you provided and report an error when it runs. How to solve this problem?
微信图片_20210622201210

You need to install an app that can handle the wallet connect interface, the url scheme is wc://. You can use an app like metamask to handle the intent.

@ww1997hj
Copy link

ww1997hj commented Jun 28, 2021

Hi, what should I do if I want to integrate Uniswap on my own app? I just opened the Uniswap Dapp from Android.That is, the implementation of the wallet connection interface APP

@JavonneM
Copy link
Author

Hi, what should I do if I want to integrate Uniswap on my own app? I just opened the Uniswap Dapp from Android.That is, the implementation of the wallet connection interface APP

I think you are misunderstanding what this library does. If you want to integrate Uniswap (a dapp) into your app your should be using the web3 to send rpc requests to the blockchain and interact with the contract.

WalletConnect is simply a protocol for connecting and signing transactions with a wallet, for example your app would build a transaction, lets say you want to swap a token on uniswap, you'd build the transaction then send it over WalletConnect library to bridge your app to some wallet(ie metamask) for signing and sending the signed transaction to the blockchain.

This library simply creates a bridge from your app to metamask. The rest of the implementation you need to do with something like web3. A link to the web3 js docs

@ligi
Copy link
Collaborator

ligi commented Jun 28, 2021

oh sorry for letting this PR slip @JavonneM - crazy times currently - hope to be able to test and maybe merge this one soon

@ww1997hj
Copy link

ww1997hj commented Jul 2, 2021

Hello, can I connect to the Uniswap Dapp by integrating this library?If so, how should I do it?Thank you. Could you give me some advice

@nghminh163
Copy link

image
You can use this instead of patch to lib :D

@mobilekosmos
Copy link

When merge?

@JavonneM
Copy link
Author

JavonneM commented Oct 5, 2021

When merge?

Still awaiting @ligi to test and merge. I think they might be working on a new version of this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants