Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all dependencies in Pr/40 #47

Open
wants to merge 5 commits into
base: pr/40
Choose a base branch
from

Conversation

mobilekosmos
Copy link

Updated all dependencies and adapted code accordingly, no business logic changed.

JavonneM and others added 3 commits May 24, 2021 10:59
DSL element 'dexOptions' is obsolete and should be removed.
It will be removed in version 8.0 of the Android Gradle plugin.
Using it has no effect, and the AndroidGradle plugin optimizes dexing automatically.

Updated gradle to version 7
Replaced maven with maven-publish

Removed kotlin extensions as required and adapted mainActivity code to this

Removed multidex lib as not needed anymore from API 21

WebSocket lib old version was full of security bugs.

For Android projects consisting of an app with library dependencies, it is recommended to set checkDependencies to true
https://developer.android.com/studio/releases/gradle-plugin#improved_lint_for_library_dependencies
@mobilekosmos
Copy link
Author

Tested with latest Android Studio Artic Fox and Gradle 7+
MinSDK changed to API 28, I'm in favor of dropping support of older versions in order to achieve a better code quality and security which is really important in such a lib.

… use KotlinJsonAdapterFactory from the moshi-kotlin artifact or use code gen from the moshi-kotlin-codegen artifact.)

+ komputing:khex version number extracted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants