Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Double to Long conversion for chainId #76

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

teresajiar
Copy link
Contributor

We discovered chainId was always set to null, the reason this was happening was because of a wrong cast from Double to Long.
Another person also reported the issue here

Fixing Double to Long conversion for chainId
ligi added a commit that referenced this pull request Jul 17, 2022
ligi added a commit that referenced this pull request Jul 17, 2022
@ligi
Copy link
Collaborator

ligi commented Jul 17, 2022

thanks - validated the fix works with #77

@ligi ligi merged commit 4b038f0 into WalletConnect:master Jul 17, 2022
github-actions bot pushed a commit that referenced this pull request Jul 17, 2022
amal pushed a commit to amal/WalletConnectKotlinV1 that referenced this pull request Apr 6, 2023
to validate PR WalletConnect#76

Signed-off-by: Artyom Shendrik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants