add theme variables to head
#30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short, adding all these custom properties directly onto the
htmlstyle attribute is kinda rude and creates a bad developer experience:This also applies to everyone using popular wallet libraries like @rainbow-me's Rainbowkit or @family's Connectkit, as they all use this library.
Solution
This PR proposes to add all theme-related custom properties into a
styletag within theheadunder the:rootpseudo class. Resulting in a clean DOM without any changes in functionality:Possible Issues
Moving CSS declarations from
htmlstyle property toheadstyle tag decreases their specificity. Which in theory should not be an issue here as we only deal with custom properties with no actual CSS rules. But as there are no tests to check this out quickly, let me know if you can think of any more issues arising because of this reduced specificity.And finally, here's a scientific representation of developer experience improvements after using this PR: