Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tma #36

Merged
merged 8 commits into from
Sep 30, 2024
Merged

feat: tma #36

merged 8 commits into from
Sep 30, 2024

Conversation

ganchoradkov
Copy link
Member

Changes

  • feat: telegram mini apps compatibility
  • fix:
  • chore:

Implemented fixes for telegram mini apps support

  • fixed native deep links
  • fixed android connection uri encoding via deeplink
  • fixed ios deep links
  • added base64 encoding of connection uri when universal links target https://t.me

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024 •
edited
Loading

Deploying lab-walletconnect-modal with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22c8bee
Status: ✅  Deploy successful!
Preview URL: https://0a85b623.lab-walletconnect-modal.pages.dev
Branch Preview URL: https://feat-tma.lab-walletconnect-modal.pages.dev

View logs

Cali93
Cali93 reviewed Sep 30, 2024
View reviewed changes
Copy link

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we test this out ? Would be great to do a mini bug bash or a few steps to follow so we can make sure it's all good 🙏

packages/modal-core/src/utils/CoreUtil.ts Outdated Show resolved Hide resolved
packages/modal-ui/src/views/wcm-connect-wallet-view/index.ts Outdated Show resolved Hide resolved
Cali93
Cali93 previously approved these changes Sep 30, 2024
View reviewed changes
Copy link

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that we update the check on window

packages/modal-core/src/utils/CoreUtil.ts Outdated Show resolved Hide resolved
enesozturk
enesozturk previously approved these changes Sep 30, 2024
View reviewed changes
@ganchoradkov ganchoradkov dismissed stale reviews from enesozturk and Cali93 via 22c8bee September 30, 2024 10:40
@ganchoradkov ganchoradkov requested a review from Cali93 September 30, 2024 10:42
Cali93
Cali93 approved these changes Sep 30, 2024
View reviewed changes
Copy link

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚢

@ganchoradkov ganchoradkov merged commit 0fb3683 into main Sep 30, 2024
5 checks passed
@ganchoradkov ganchoradkov deleted the feat/tma branch September 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali93 Cali93 Cali93 approved these changes

@enesozturk enesozturk enesozturk left review comments

@svenvoskamp svenvoskamp Awaiting requested review from svenvoskamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganchoradkov @enesozturk @Cali93